🎨 [Frontend] PO Center: Approval/Deny of account requests #8046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
|
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactors the user review flow by renaming “Pending Users” to “Review Users,” streamlining approval/rejection actions with confirmation dialogs, status icons, and automatic reloads.
- Renames “Pending Users” tab to “Review Users” and always enables it
- Replaces old approve/reject buttons with
__createApproveButton/__createRejectButton, adding confirmation pop-ups - Introduces status icons, sorts by review date, and adds an auto-reload helper
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/po/UsersPending.js | Overhauled approval/rejection logic: added confirmation dialogs, status icons, reload logic, and function renames |
| services/static-webserver/client/source/class/osparc/po/POCenter.js | Renamed and always includes the “Review Users” tab instead of a development-only page |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/po/UsersPending.js:321
- The template string for the reject confirmation message has an extra double quote and embeds HTML (
<br>), which may lead to malformed output or unexpected behavior. Remove the stray quote and consider using a newline or UI-provided formatting instead of raw HTML.
const msg = `Are you sure you want to reject ${email}.<br>The operation cannot be reverted"`;
Member
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 04ffd16 |
giancarloromeo
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are you sure you want to reject {email}. The operation cannot be revertedAre you sure you want to approve {email} with 100$ credit and expired=3days. We will proceed to send an invitation email?Review UsersaccountRequestReviewedAtRelated issue/s
How to test
Dev-ops